Repository navigation
Export: one fixed note under the share link - #107
Merged
Merged
Conversation
… knew The note under the project's link waited for the server's list of links (about a second). Projects with a video behind their link are now kept in shared-projects in the config folder, so the dialog opens with the right note; the server's answer corrects it in the background.
The note under the project's link changed with what was known about its upload. It is now the same sentence everywhere (settings and the progress dialog). The app no longer asks the server for its links or keeps an uploaded-projects cache: the link is derived from the project id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The note under the project's share link changed with the upload state (and appeared only after a server lookup). It is now one sentence, shown at once in both the settings and the progress dialog: "This project's link. Export with “Make a share link too” to put the latest video behind it."
The link is derived from the project id, so the app no longer lists links from the server or keeps an uploaded-projects cache (both removed). Upload progress, Cancel and a failed upload's error still show.